Merged
Conversation
Contributor
|
I personally think forcing lint on commits is a bit heavy handed - our CI already runs lint so I don't think it's totally necessary. |
Member
|
I think with pre-commit hook we can detect the problem right away without waiting for the CI to fail and prevent some unnecessary commit like "fixed lint" 😄 |
Contributor
|
Maybe also have it run the tests? |
Member
|
LGTM but can you discard |
Contributor
Author
|
@ZeroX-DG I agree with you since the tests are heavy. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is running the
lintcommand before a commit.